Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename aux files #221

Closed
wants to merge 7 commits into from
Closed

Conversation

FredSchuller
Copy link
Collaborator

@FredSchuller FredSchuller commented Aug 15, 2024

Updated name of L2 AUX files to solo_ANC_stix-asp-ephemeris*

Copy link
Collaborator

@samaloney samaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but should prob wait for @nicHoch too

@FredSchuller
Copy link
Collaborator Author

Sure, makes sense. I'll be off until Sept. 2nd but please proceed :-)

@FredSchuller
Copy link
Collaborator Author

Note that function stx_get_ephemeris_file will now look for files with name 'stix-asp-ephemeris.fits' and that will only work once the files have been updated on the data server.

@samaloney
Copy link
Collaborator

samaloney commented Oct 14, 2024

I guess this can be finalised now the the SOAR has accepted our test file @nicHoch?

Would it be hard to support the older name too, at least for a while?

@samaloney samaloney linked an issue Oct 15, 2024 that may be closed by this pull request
@FredSchuller
Copy link
Collaborator Author

so should I change the way stx_get_ephemeris_file works so that it looks for the new names and then for the old ones if nothing found?

@FredSchuller
Copy link
Collaborator Author

@samaloney @ennosigaeus
I just created a new PR (#228) that includes all changes, also making things compatible with the previous AUX filenames.
Since I was about to generate a big mess when trying to include the recent changes, I preferred to start again from the up-to-date i4Ds/master branch and make only the necessary changes. Therefore PR #221 should simply be trashed...

@samaloney samaloney closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update naming convention for ephemeris files
2 participants