Fix bugs found when processing new scaled trigger data. #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
samaloney
commented
Feb 15, 2024
samaloney
commented
- Allow for QL files to unscale by packet
- Fix bug the replicate extra triggers in Spectrogram
* Allow for QL file to unscale by batch * Fix bug the replicate extra triggers in Spectrogram
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #382 +/- ##
==========================================
+ Coverage 77.10% 77.12% +0.01%
==========================================
Files 66 66
Lines 6906 6925 +19
==========================================
+ Hits 5325 5341 +16
- Misses 1581 1584 +3 ☔ View full report in Codecov by Sentry. |
|
Hum I need to check some of the differences in the end2end tests ... |
nicHoch
approved these changes
Feb 22, 2024
samaloney
commented
Mar 21, 2024
Comment on lines
+160
to
+168
| for i, (num, skm) in enumerate(zip(control['num_samples'], | ||
| control['compression_scheme_triggers_skm'])): | ||
| if skm.tolist() == _SKM_SCALING: | ||
| cur_slice = slice(cur_index, cur_index+num) | ||
| logger.debug('Unscaling triggers') | ||
| triggers[cur_slice], triggers_var[cur_slice] = unscale_triggers( | ||
| triggers[cur_slice], integration=duration[cur_slice], | ||
| detector_masks=control['detector_mask'][i:i+1], ssid=levelb.ssid) | ||
| cur_index += num |
There was a problem hiding this comment.
Possible optimisation and could be extended for the other science data is rather than looping over all packets loop over data where skm apply as usually only 1 skm and in the vast majority of cases the number of different skm << num of packets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.