Option to inverse checkmark widget On/Off colours #2092
Closed
+57
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR, @JollyGood1; it looks well implemented. However, I don't think this feature should be added to the app. We are trying to keep the widgets consistent with the main interface. If anyone is interested in it, feel free to use this build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the feature discussed in #2091.
Added option to choose to invert the checkmark widgets colours, making the colourful version a call to action.
I'm not 100% sure about the what colour the UNKNOWN state should be because I don't really understand when it happens. I kept it the same as NO.
I've never contributed in github or ever coded for android, so feel free to tell me if I did something wrong.