Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate BrowserAuthCallbackHandler and BrowserAuthorizationClient #123

Merged
merged 16 commits into from
Mar 21, 2023

Conversation

ben-polinsky
Copy link
Collaborator

@ben-polinsky ben-polinsky commented Mar 7, 2023

Merge BrowserAuthCallbackHandler into BrowserAuthorizationClient

Fixes: #103

@ben-polinsky
Copy link
Collaborator Author

I've tested this out using the integration tests in #119 and they pass, FYI

Copy link
Member

@aruniverse aruniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for killing off the static

@aruniverse
Copy link
Member

I've tested this out using the integration tests in #119 and they pass, FYI

lets get that pr merged in before this

@ben-polinsky ben-polinsky enabled auto-merge (squash) March 8, 2023 20:19
@WillGrayMSU WillGrayMSU self-requested a review March 14, 2023 14:34
@aruniverse
Copy link
Member

@WillGrayMSU did you pull this into DR and test in a CoSpace to verify this worked fine?

@WillGrayMSU
Copy link

@WillGrayMSU did you pull this into DR and test in a CoSpace to verify this worked fine?

I haven't, but I can try now

Copy link

@WillGrayMSU WillGrayMSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

types need to be exported

packages/browser/src/index.ts Outdated Show resolved Hide resolved
@ben-polinsky
Copy link
Collaborator Author

@aruniverse I'm unable to test the cra-template due to some annoying pre-release/peer deps constraints. Perhaps we should publish this as a pre-release or alpha to test.

Copy link
Member

@aruniverse aruniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting a pre-release out will be annoying, since the change is marked as minor and its currently 0.x, no one should be pulling this in automatically. i guess we can test once released

packages/browser/README.md Outdated Show resolved Hide resolved
@ben-polinsky
Copy link
Collaborator Author

getting a pre-release out will be annoying, since the change is marked as minor and its currently 0.x, no one should be pulling this in automatically. i guess we can test once released

Maybe it should be major... it's a breaking change

@aruniverse
Copy link
Member

getting a pre-release out will be annoying, since the change is marked as minor and its currently 0.x, no one should be pulling this in automatically. i guess we can test once released

Maybe it should be major... it's a breaking change

according to semver, breaking changes are allowed in 0.x

@ben-polinsky
Copy link
Collaborator Author

getting a pre-release out will be annoying, since the change is marked as minor and its currently 0.x, no one should be pulling this in automatically. i guess we can test once released

Maybe it should be major... it's a breaking change

according to semver, breaking changes are allowed in 0.x

the more you know! Thanks

@ben-polinsky ben-polinsky enabled auto-merge (squash) March 21, 2023 18:04
@ben-polinsky ben-polinsky merged commit c22e4e5 into main Mar 21, 2023
@ben-polinsky ben-polinsky deleted the bdp/102/consolidate-browser-auth-callback-handler branch March 21, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate BrowserAuthorizationCallbackHandler into BrowserAuthorizationClient
4 participants