-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate BrowserAuthCallbackHandler and BrowserAuthorizationClient #123
Consolidate BrowserAuthCallbackHandler and BrowserAuthorizationClient #123
Conversation
I've tested this out using the integration tests in #119 and they pass, FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for killing off the static
...rowser-authorization/bdp-102-consolidate-browser-auth-callback-handler_2023-03-07-17-13.json
Outdated
Show resolved
Hide resolved
lets get that pr merged in before this |
@WillGrayMSU did you pull this into DR and test in a CoSpace to verify this worked fine? |
I haven't, but I can try now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
types need to be exported
@aruniverse I'm unable to test the cra-template due to some annoying pre-release/peer deps constraints. Perhaps we should publish this as a pre-release or alpha to test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getting a pre-release out will be annoying, since the change is marked as minor and its currently 0.x, no one should be pulling this in automatically. i guess we can test once released
Co-authored-by: Arun George <[email protected]>
Maybe it should be major... it's a breaking change |
according to semver, breaking changes are allowed in 0.x |
the more you know! Thanks |
Merge BrowserAuthCallbackHandler into BrowserAuthorizationClient
Fixes: #103