This repository has been archived by the owner on Jan 5, 2023. It is now read-only.
feat(Table): onFilter gets filtered rows
#958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamhock
requested review from
a team,
gretanausedaite and
elephantcatdog
and removed request for
a team
bentleyvk
reviewed
Dec 7, 2022
bentleyvk
reviewed
Dec 7, 2022
bentleyvk
reviewed
Dec 7, 2022
…am/get-filtered-rows
subrows have been tested! |
gretanausedaite
approved these changes
Dec 9, 2022
…am/get-filtered-rows
…am/get-filtered-rows
elephantcatdog
approved these changes
Dec 13, 2022
…am/get-filtered-rows
mayank99
pushed a commit
to iTwin/iTwinUI
that referenced
this pull request
Dec 21, 2022
* `onFilter` now has an additional parameter `filteredData` which users can get their filtered rows from.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onFilternow has an additional parameterfilteredDatawhich users can get their filtered rows from.onFilteris now called inTable.tsxinstead offilterHandler.tsbecause there's no way to get filtered rows in the state reducer. Because of this,onFilterHandlernow only returns the filters.previousFilterandcurrentFilterare used to track when the filters are changed soonFilteris only called when this occurs. These are checked in a.useEffectafter thestateReducerruns all the handling.Closes #816