Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace useTheme with internal useGlobals #1265

Merged
merged 22 commits into from
May 17, 2023
Merged

replace useTheme with internal useGlobals #1265

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
ca216ac
remove useTheme hook
mayank99 May 9, 2023
6116aea
better name
mayank99 May 9, 2023
eb2cf62
jsdoc
mayank99 May 10, 2023
c6ee225
Merge branch 'main' into mayank/remove-usetheme
mayank99 May 10, 2023
65ec0f2
remove tests for fallback
mayank99 May 10, 2023
d17589c
leftover merge
mayank99 May 10, 2023
9dc032a
remove deprecated prop
mayank99 May 10, 2023
55c6d82
leftover md
mayank99 May 10, 2023
55bca31
remove story instance
mayank99 May 10, 2023
577da92
add changeset
mayank99 May 10, 2023
25ba60e
show warning if themeprovider not used
mayank99 May 10, 2023
ff3ccfa
consistent names
mayank99 May 10, 2023
2a51f4f
more descriptive warning
mayank99 May 10, 2023
cf8efa0
story hack
mayank99 May 10, 2023
b10509f
fix storybook-dark-mode and backgrounds
mayank99 May 10, 2023
8f1c603
fix ColorPicker appendTo
mayank99 May 10, 2023
d3c5c9e
use key to force remount
mayank99 May 12, 2023
3d25814
Merge branch 'main' into mayank/remove-usetheme
mayank99 May 12, 2023
c92565f
use `isDomAvailable` instead of `key`
mayank99 May 12, 2023
5e10492
Merge branch 'main' into mayank/remove-usetheme
mayank99 May 12, 2023
dbae00f
use hook that's already available
mayank99 May 15, 2023
744e4e1
Merge branch 'dev' into mayank/remove-usetheme
mayank99 May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove deprecated prop
  • Loading branch information
@mayank99
mayank99 committed May 10, 2023
commit 9dc032a7372c291ab5aa311fe4806b49ad5ad249
9 changes: 0 additions & 9 deletions packages/itwinui-react/src/core/ThemeProvider/ThemeProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,6 @@ import type {
} from '../utils/index.js';

type ThemeOptions = {
/**
* Document to which the theme will be applied.
* Can be specified to handle popup windows.
* @default document
*
* @deprecated This prop will continue to work in `useTheme` but
* we recommend rendering `ThemeProvider` in the correct document instead.
*/
ownerDocument?: Document;
/**
* Whether to apply high-contrast versions of light and dark themes.
* Will default to user preference if browser supports it.
Expand Down