Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typecasting forwardRef inside Select #1774

Merged
merged 16 commits into from
Jan 11, 2024
Merged

Typecasting forwardRef inside Select #1774

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e5bf491
added type for forward ref.
siddhantrawal Jan 8, 2024
0bf9044
Merge branch 'main' into siddhant/select_argument
siddhantrawal Jan 8, 2024
c08af71
adding ref as props.
siddhantrawal Jan 8, 2024
812991e
Merge branch 'main' into siddhant/select_argument
siddhantrawal Jan 9, 2024
b6aa70f
Revert "adding ref as props."
siddhantrawal Jan 9, 2024
eb9cb64
Revert "added type for forward ref."
siddhantrawal Jan 9, 2024
0cf4647
adding type assertion at the end of select component.
siddhantrawal Jan 9, 2024
c5732a4
adding type assertion at the end of Labeledselect component.
siddhantrawal Jan 9, 2024
6c0dc4a
Added type testcases.
siddhantrawal Jan 10, 2024
66da437
Added more different type of test cases.
siddhantrawal Jan 10, 2024
bdaa261
update onChange check,
siddhantrawal Jan 10, 2024
a541956
Added unit test cases.
siddhantrawal Jan 10, 2024
f315591
updating test cases to check for custom attribute.
siddhantrawal Jan 11, 2024
9c481a7
added force check type and changeset.
siddhantrawal Jan 11, 2024
26a8ea4
Update .changeset/lovely-pears-talk.md
siddhantrawal Jan 11, 2024
b045fbd
removed extra example.
siddhantrawal Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 43 additions & 9 deletions packages/itwinui-react/src/core/LabeledSelect/LabeledSelect.types-test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,25 +7,59 @@
* (e.g. react-workshop, unit tests, etc.)
*/

import React from 'react';
import React, { useRef } from 'react';
import LabeledSelect from './LabeledSelect.js';

const App = () => {
() => {
const ref = useRef(null);
return (
<>
<LabeledSelect<string>
label='Select Label'
<LabeledSelect
options={[
{ value: '1', label: '1' },
{ value: '2', label: '2' },
{ value: '3', label: '3' },
{ value: 1, label: 'Option 1' },
{ value: 2, label: 'Option 2' },
{ value: 3, label: 'Option 3' },
]}
onChange={(value) => {
console.log(value);
return value;
}}
ref={ref}
/>
</>
);
};

() => {
return (
<>
<LabeledSelect<number>
options={[
{ value: 1, label: 'Option 1' },
{ value: 2, label: 'Option 2' },
{ value: 3, label: 'Option 3' },
]}
onChange={(value: number) => {
return value;
}}
/>
</>
);
};

export default App;
() => {
return (
<>
<LabeledSelect<string>
label='Select Label'
options={[
{ value: '1', label: 'Item #1' },
{ value: '2', label: 'Item #2' },
{ value: '3', label: 'Item #3' },
r100-stack marked this conversation as resolved.
Show resolved Hide resolved
]}
onChange={(value: string) => {
return value;
}}
/>
</>
);
};
50 changes: 42 additions & 8 deletions packages/itwinui-react/src/core/Select/Select.types-test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,24 +7,58 @@
* (e.g. react-workshop, unit tests, etc.)
*/

import React from 'react';
import React, { useRef } from 'react';
import Select from './Select.js';

const App = () => {
() => {
const ref = useRef(null);
return (
<>
<Select<string>
<Select
options={[
{ value: '1', label: '1' },
{ value: '2', label: '2' },
{ value: '3', label: '3' },
{ value: 1, label: 'Option 1' },
{ value: 2, label: 'Option 2' },
{ value: 3, label: 'Option 3' },
]}
onChange={(value) => {
console.log(value);
return value;
r100-stack marked this conversation as resolved.
Show resolved Hide resolved
}}
ref={ref}
/>
</>
);
};

() => {
return (
<>
<Select<number>
options={[
{ value: 1, label: 'Option 1' },
{ value: 2, label: 'Option 2' },
{ value: 3, label: 'Option 3' },
]}
onChange={(value: number) => {
return value;
}}
/>
</>
);
};

export default App;
() => {
return (
<>
<Select<string>
options={[
{ value: '1', label: 'Option 1' },
{ value: '2', label: 'Option 2' },
{ value: '3', label: 'Option 3' },
]}
onChange={(value: string) => {
return value;
}}
/>
</>
);
};
Loading