Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Tree JSDoc and website documentation #2361

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Conversation

smmr-dn
Copy link
Contributor

@smmr-dn smmr-dn commented Dec 5, 2024

Changes

This PR updated the Tree JSDoc and website documentation to mention the issue user reported. The issue discussed the requirement for the Tree's nodeRenderer to return a component wrapped with React.forwardRef, ensuring proper application of styling and other props to virtualized small Tree.

Testing

All tests passed.

Docs

N/A

@smmr-dn smmr-dn marked this pull request as ready for review December 6, 2024 21:02
@smmr-dn smmr-dn requested a review from a team as a code owner December 6, 2024 21:02
@smmr-dn smmr-dn requested review from mayank99 and r100-stack and removed request for a team December 6, 2024 21:02
Copy link
Member

@r100-stack r100-stack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the existing comments are resolved

@smmr-dn smmr-dn linked an issue Dec 10, 2024 that may be closed by this pull request
1 task
@smmr-dn smmr-dn merged commit b0f9f45 into main Dec 10, 2024
17 of 18 checks passed
@smmr-dn smmr-dn deleted the uyen/updated-tree-doc branch December 10, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree["nodeRenderer"] has hidden requirement to forward ref to underlying TreeNode
3 participants