-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduced small Select
's content height to be consistent with small ComboBox
#2362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the centering. There shouldn't be any test image changes in stories that don't use the small Select.
I figured when I used the fallback values (--iui-size-l) for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
As user reported the issue regarding the height difference between small
ComboBox
andSelect
, this PR reduced themin-block-size
andline-height
of the content inside smallSelect
to--iui-size-m
so that the overall height would not exceed 24px.Testing
Approved test screenshots.
Docs
Added changesets for
itwinui-react
anditwinui-css
packages.