Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced small Select's content height to be consistent with small ComboBox #2362

Merged
merged 11 commits into from
Dec 10, 2024

Conversation

smmr-dn
Copy link
Contributor

@smmr-dn smmr-dn commented Dec 5, 2024

Changes

As user reported the issue regarding the height difference between small ComboBox and Select, this PR reduced the min-block-size and line-height of the content inside small Select to --iui-size-m so that the overall height would not exceed 24px.

Before After

Testing

Approved test screenshots.

Docs

Added changesets for itwinui-react and itwinui-css packages.

@smmr-dn smmr-dn marked this pull request as ready for review December 6, 2024 21:03
@smmr-dn smmr-dn requested a review from a team as a code owner December 6, 2024 21:03
@smmr-dn smmr-dn requested review from mayank99 and r100-stack and removed request for a team December 6, 2024 21:03
Copy link
Contributor

@mayank99 mayank99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the centering. There shouldn't be any test image changes in stories that don't use the small Select.

@smmr-dn
Copy link
Contributor Author

smmr-dn commented Dec 9, 2024

Please fix the centering. There shouldn't be any test image changes in stories that don't use the small Select.

I figured when I used the fallback values (--iui-size-l) for min-block-size and line-height for other sizes, it returned 21px instead of 24px, which eventually caused the texts to be un-centered. I tried specifying the min-block-size and line-height vars for medium and large size. The screenshots have been corrected as well.

@r100-stack r100-stack linked an issue Dec 9, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

@mayank99 mayank99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smmr-dn smmr-dn merged commit 78ae415 into main Dec 10, 2024
18 checks passed
@smmr-dn smmr-dn deleted the uyen/select-line-height branch December 10, 2024 21:40
@imodeljs-admin imodeljs-admin mentioned this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select and ComboBox with size small have different heights
3 participants