Close nested MenuItems within Tile.MoreOptionswhen clicked
#2452
+217
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
reviewed
Feb 28, 2025
| @@ -111,6 +112,7 @@ export const MenuItem = React.forwardRef((props, forwardedRef) => { | |||
| } | |||
|
|
|||
| const parentMenu = React.useContext(MenuContext); | |||
| const tileMoreOptionsContext = React.useContext(TileMoreOptionsContext); | |||
There was a problem hiding this comment.
Tile depends on Menu/MenuItem but the vice-versa is not true, so it would be nice to decouple this component from Tile.
We could create a context in Menu/MenuItem such that when it's set (to true), the Menu will automatically close. Then we can provide this context from Tile.MoreOptions.
As a bonus, this approach would allow Tile.MoreOptions to stay uncontrolled (i.e. it no longer needs to pass visible to DropdownMenu).
There was a problem hiding this comment.
Good idea! Implemented (2ac45b6).
There was a problem hiding this comment.
Just realized, this approach will only close the menu directly above it. It won't close the top-most menu which is want we want. Finding a solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #2451.
Upon discussing internally, looks like handling the MenuItem closing on click instead of exposing the
closefunction to the user was intentional.The existing
cloneElementapproach works only for top-level MenuItems withinTile.MoreOptions. So, this PR uses a context approach to automatically close the menu upon clicking even the nestedMenuItems.This PR adds a context called
MenuCloseOnClickContext. This wraps around aMenuor a component that contains aMenu. When set to true, any descendant MenuItem click will close the menu.Testing
Added e2e test.
Docs
Added changeset.