Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating alteration data w.r.t. updated label #114

Open
ugurdogrusoz opened this issue Jan 24, 2018 · 7 comments
Open

Updating alteration data w.r.t. updated label #114

ugurdogrusoz opened this issue Jan 24, 2018 · 7 comments
Labels
enhancement Enhancement to existing feature
Milestone

Comments

@ugurdogrusoz
Copy link
Contributor

Looks like we're not paying attention to updated labels when it comes to alteration data. For instance, if you load some alteration data when a node's label is incorrect and then change the node label to the correct value, you expect the alteration data to be shown for the new label. Similarly, if you add a new node to the pathway after loading experiment data, you expect the data to be shown as well. Neither seems to happen right now!

@ugurdogrusoz ugurdogrusoz added the enhancement Enhancement to existing feature label Jan 24, 2018
@ugurdogrusoz ugurdogrusoz added this to the 2.0 milestone Jan 24, 2018
@ugurdogrusoz
Copy link
Contributor Author

One option here is to automatically update alteration data upon changes (e.g. addition of a new gene or label change of a gene) or we could provide a new menu item to "re-load/update" alteration data. Let's discuss.

@leonarddrv
Copy link
Contributor

Addition of this functionality is not straightforward for both approaches (updated labels case and menu option) because the previous queries to retrieve genomic data are not saved. Also the structure of collaborative mode data need to be changed accordingly.

@leonarddrv leonarddrv modified the milestones: 2.0, future Feb 16, 2018
@ugurdogrusoz
Copy link
Contributor Author

Thx, lets get back to this later then

@ugurdogrusoz
Copy link
Contributor Author

@msalihaltun What do you think about this issue? If label changes cannot be directly caught and experiment data updated accordingly, can we perhaps add an Update alteration data menu item or something?

@msalihaltun
Copy link
Contributor

The earlier comments are correct. We don't remember specific params about currently loaded queries (which data types we loaded from which study). This would not be a straightforward change.

@ugurdogrusoz
Copy link
Contributor Author

How about an Update menu item / tool in the toolbar? That is, updating only when the user explicitly applies this operation? Is this easily doable?

@msalihaltun
Copy link
Contributor

No, it wouldn't be. The same problem would occur.

Essentially, there are two issues. First we would need to remember the currently loaded study parameters (study ID and which boxes were ticked, e.g Mutation etc.). This requires some changes in the design, including collaborative data model. This should be doable, though I'm not sure how much needs to change. There are some aspects of how we keep the data (grouping and such) that I'm not very familiar with.

Second, we probably either need to remove all data and make a new query with the current list of nodes or just for the nodes that the change was made for (which I am not sure is doable). Removing all data from the DB would be a first step, but we should also make sure there are no race conditions (basically we should make sure the data is deleted from the DB before making any queries again) or other problems(?) here. There could be a bunch of things to consider.

This is why I'm hesitant to say it is easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature
Projects
None yet
Development

No branches or pull requests

3 participants