New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WEB_UI_API_URL #241

Open

lachlan2k wants to merge 1 commit into iam4x:master from lachlan2k:fix-api-url

Contributor

lachlan2k commented Apr 23, 2022

The current implementation for WEB_UI_API_URL doesn't work. This is because:

Environment variables in the frontend are added at buildtime, not runtime.
Environment variables aren't exported to the Next.js frontend, unless they start with NEXT_PUBLIC.

This PR fixes this issue by using Next.js runtime configuration instead.


          Use runtime config instead of env for api url

cff3e7f

Contributor Author

lachlan2k commented Apr 23, 2022

Ah sorry, I only tested this in dev. Bear with me and I'll fix it for full builds soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet