Update #185
Closed
Update #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encoding the Filename:
Removed a redundant assignment of escaped_fn.
Used a single assignment to properly encode and decode the filename.
File Handling:
Changed how the file is opened and processed using a with statement.
This ensures the file is closed automatically after processing.
Error Handling:
Added handling for cases where a file is not found (FileNotFoundError).
Added a catch-all exception handler for other unexpected errors.
Logging:
Improved log messages for better context and readability.
Included specific messages for file not found and processing errors.
Printing:
Replaced print() with logger.info('') for consistency in logging.
Exception Handling in logger.info():
Made sure that any errors when formatting log messages are caught.
User-Friendly Messages:
Provided clearer messages when a file is not found or when errors occur.
Argument Parsing and Main Function:
Added type hints to function signatures for better code understanding.
Update EXIF.py
Exception Handling and Assertions: The original code contained comments that explained the purpose of exceptions and assertions. Since comments are removed, you will need to refer to the original code if you need detailed explanations on these parts. Consistency and Formatting: Minor formatting changes were applied to ensure consistent indentation and spacing, maintaining Python's PEP 8 style guide. Asserting Exif Data Location: The final find_exif() function asserts that the Exif data is correctly located in the HEIC file. This involves checking offsets and verifying that the Exif header is in the expected format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception Handling and Assertions:
The original code contained comments that explained the purpose of exceptions and assertions. Since comments are removed, you will need to refer to the original code if you need detailed explanations on these parts.
Consistency and Formatting:
Minor formatting changes were applied to ensure consistent indentation and spacing, maintaining Python's PEP 8 style guide.
Asserting Exif Data Location:
The final find_exif() function asserts that the Exif data is correctly located in the HEIC file. This involves checking offsets and verifying that the Exif header is in the expected format.