-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Deliverfile related functionality #3
Remove Deliverfile related functionality #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small note about the title of a spec, otherwise looks good!
Note: reminder to reviewers that we might want to wait for us to ensure all the client apps have been updated to stop relying on the
Deliverfile
to provide theapp_version
anymore first, before we can land this change.
Better have the client apps ready before we ship the major version of the toolkit, rather than those client apps being blocked from updating the release-toolkit (e.g. if we need a new thing that will land in the release-toolkit after that change, but the client were still relying on the app_version
being defined in Deliverfile
, but we might not have time/priority to fix that aspect in the client then…)
1cad793
to
976d67d
Compare
976d67d
to
acae9e7
Compare
Co-authored-by: Olivier Halligon <[email protected]>
EDIT: This PR was re-created in the main repo as wordpress-mobile#450
What does it do?
On this discussion I had with @AliSoftware he mentioned that using the
Deliverfile
to configure the app version became obsolete, so this PR removes all references to it.It implements:
include_deliverfile
parameter inIos::GitHelper.commit_version_bump()
and all call sites.skip_deliver
ConfigItem in the actionsios_bump_version_hotfix
andios_bump_version_release.rb
.Ios::VersionHelper::update_fastlane_deliver()
.Related PRs
skip_glotpress
and related cleanup wordpress-mobile/release-toolkit#443 .Next steps
The idea is that the current
Ios::GitHelper.commit_version_bump()
will become obsolete, given now all it does is committing the hard-coded/config/
folder. So based on this work, we can also removeIos::GitHelper.commit_version_bump()
and commit the.xcconfig
directly from where it's being changed.Checklist before requesting a review
bundle exec rubocop
to test for code style violations and recommendationsspecs/*_spec.rb
) if applicablebundle exec rspec
to run the whole test suite and ensure all your tests passCHANGELOG.md
file to describe your changes under the approprioate existing###
subsection of the existing## Trunk
section.