Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selections with non-void non-editable focus #5716

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Fix selections with non-void non-editable focus #5716

merged 5 commits into from
Sep 12, 2024

Commits on Sep 9, 2024

  1. Fix selections with non-void non-editable focus 

    "Non-void non-editable" refers to `contentEditable={false}` DOM nodes
that are rendered by a Slate element render but which are not void
elements. For instance, [the checkboxes in the checklists example][1].

[1]: https://github.com/ianstormtaylor/slate/blob/7e77a932f0489a9fff2d8a1957aa2dd9b324aa78/site/examples/check-lists.tsx#L153-L170
    @TyMick
    TyMick committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    171e0d8 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. fixup! Fix selections with non-void non-editable focus 

    Optimize leaf node search
    @TyMick
    TyMick committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9534c21 View commit details
    Browse the repository at this point in the history

  2. fixup! Fix selections with non-void non-editable focus 

    Rename `focusNodeSelectable` to `focusNodeIsSelectable`

A more accurate name given this PR's changes.
    @TyMick
    TyMick committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    98630d1 View commit details
    Browse the repository at this point in the history

  3. fixup! Fix selections with non-void non-editable focus 

    Remove inapplicable `if` branch
    @TyMick
    TyMick committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    1f368a9 View commit details
    Browse the repository at this point in the history

  4. fixup! Fix selections with non-void non-editable focus 

    Improve comment
    @TyMick
    TyMick committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    f4654c3 View commit details
    Browse the repository at this point in the history