-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made template for showing image_field in admin-ui more robust #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedIssues Measures |
Steveb-p
reviewed
Nov 4, 2024
src/bundle/Resources/views/themes/admin/ui/field_type/preview/content_fields.html.twig
Outdated
Show resolved
Hide resolved
…content_fields.html.twig Co-authored-by: Paweł Niedzielski <[email protected]>
Quality Gate passedIssues Measures |
Steveb-p
approved these changes
Dec 17, 2024
bdunogier
approved these changes
Dec 17, 2024
konradoboza
approved these changes
Dec 17, 2024
ViniTou
approved these changes
Dec 17, 2024
@ViniTou or anyone... Is QA really needed for this PR ? |
@vidarl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I was not able to reproduce the problem on a fresh 4.6, but on a installation just upgraded to 4.6 (was at some point using 2.5 or maybe even older releases) the database had a lot of images with the following "empty" data in
ezcontentobject_attribute.data_text
:In 4.6, the value will simply be
null
if no image is uploaded. However, in earlier versions it was obviously stored like shown above. And one problem here is thatheight
has a value set to empty string. The admin-ui template requiresheight
to be numeric or aUnsupported operand types: string / string
exception will be thrown.It would be nice if twig had a
is numeric
test but that is not going to happend. For this use-case it is sufficient to check if value is empty string tooFor QA:
Documentation: