Skip to content

IBX-9519: [Behat] Added basic test coverage for content tree #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 4.6
Choose a base branch
from

Conversation

juskora
Copy link
Contributor

@juskora juskora commented Mar 14, 2025

| 🎫 Issue |https://issues.ibexa.co/browse/IBX-9519|

Description:

Further development plans:

  • add test scenario for removing content item from the tree
  • add test scenario for collapsing items on content tree

For QA:

Documentation:

@juskora juskora marked this pull request as ready for review March 14, 2025 11:14
@juskora juskora requested a review from a team March 14, 2025 11:19
@juskora juskora force-pushed the IBX-9519-behat-coverage-contentree branch from ad25b6a to 9ed7408 Compare March 14, 2025 11:36
Copy link
Contributor

@katarzynazawada katarzynazawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on your first behat tests! 😄
It seems that these scenarios might be missing a direct verification if the content tree is visible and what it includes. Currently, only the content view is being verified, and there is a possibility that the check might pass even if, for some reason, the content tree is not displayed. I would suggest adding some new steps to check what is visible in the content tree.

Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juskora What do we need in order to finalize this PR ?

use Ibexa\Behat\Browser\Locator\VisibleCSSLocator;


class ContentTree extends Component
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class ContentTree extends Component
final class ContentTree extends Component

Comment on lines +17 to +18


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants