IBX-9060: Revamp notifications #1529
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albozek
requested review from
GrabowskiM,
tischsoic,
dew326,
vexleet,
OstafinL,
RopRaptor and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR revamps the notifications functionality and introduces new sidebar interactions while updating related configuration and routing. Key changes include:
- Introducing a new sidebar panel with improved event handling and backdrop management.
- Revamping notifications modal and list functionality by adding support for actions such as marking notifications as read/unread, bulk operations, and deletion.
- Updating routing, service configurations, and default settings to support the new notifications features.
Reviewed Changes
Copilot reviewed 27 out of 38 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/bundle/Resources/public/js/scripts/sidebar/side.panel.js | New sidebar panel implementation with close triggers and backdrop control. |
| src/bundle/Resources/public/js/scripts/admin.notifications.modal.js | Updates to notifications modal including new actions and improved event management. |
| src/bundle/Resources/public/js/scripts/admin.notifications.list.js | Introduction of notifications list with bulk operations and status management. |
| src/bundle/Resources/public/js/scripts/admin.notifications.filters.js | New filters implementation for notifications. |
| src/bundle/Resources/public/js/scripts/admin.multilevel.popup.menu.js | Improvement in multilevel popup menu initialization with refactored event handling. |
| src/bundle/Resources/encore/ibexa.js.config.js | Updated configuration to include new notifications list entry. |
| src/bundle/Resources/config/services/controllers.yaml | Added new controller service definitions for notifications. |
| src/bundle/Resources/config/routing.yaml | Introduced new routes to support notifications actions. |
| src/bundle/Resources/config/ezplatform_default_settings.yaml | Increased pagination limit for notifications. |
Files not reviewed (11)
- src/bundle/Controller/AllNotificationsController.php: Language not supported
- src/bundle/Controller/NotificationController.php: Language not supported
- src/bundle/Form/Data/SearchQueryData.php: Language not supported
- src/bundle/Form/Type/SearchType.php: Language not supported
- src/bundle/Resources/public/scss/_header-user-menu.scss: Language not supported
- src/bundle/Resources/public/scss/_list-filters.scss: Language not supported
- src/bundle/Resources/public/scss/_notifications-modal.scss: Language not supported
- src/bundle/Resources/public/scss/_notifications.scss: Language not supported
- src/bundle/Resources/public/scss/_side-panel.scss: Language not supported
- src/bundle/Resources/public/scss/ibexa.scss: Language not supported
- src/bundle/Resources/translations/ibexa_admin_ui.en.xliff: Language not supported
Comments suppressed due to low confidence (1)
src/bundle/Resources/public/js/scripts/admin.multilevel.popup.menu.js:2
- [nitpick] The function name 'initMutlilevelPopupMenus' appears to contain a typographical error; consider renaming it to 'initMultilevelPopupMenus' for clarity.
const initMutlilevelPopupMenus = (container) => {
src/bundle/Resources/public/js/scripts/admin.notifications.list.js
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: