Improved exception message for a non-unique language code (#281)

ibexa · Oct 11, 2023 · 0ef85fa · 0ef85fa
1 parent 22f4600
commit 0ef85fa
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/lib/Repository/LanguageService.php b/src/lib/Repository/LanguageService.php
@@ -90,7 +90,10 @@ public function createLanguage(LanguageCreateStruct $languageCreateStruct): Lang
 
         try {
             if ($this->loadLanguage($languageCreateStruct->languageCode) !== null) {
-                throw new InvalidArgumentException('languageCreateStruct', 'language with the specified language code already exists');
+                throw new InvalidArgumentException(
+                    'languageCreateStruct',
+                    sprintf('language with the "%s" language code already exists', $languageCreateStruct->languageCode)
+                );
             }
         } catch (APINotFoundException $e) {
             // Do nothing

diff --git a/tests/integration/Core/Repository/LanguageServiceTest.php b/tests/integration/Core/Repository/LanguageServiceTest.php
@@ -128,7 +128,7 @@ public function testCreateLanguageSetsExpectedProperties($language)
     public function testCreateLanguageThrowsInvalidArgumentException()
     {
         $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('Argument \'languageCreateStruct\' is invalid: language with the specified language code already exists');
+        $this->expectExceptionMessage('Argument \'languageCreateStruct\' is invalid: language with the "nor-NO" language code already exists');
 
         $repository = $this->getRepository();