Added early return from validation when content is not an asset

ibexa · Jan 12, 2024 · 44d9fbb · 44d9fbb
1 parent c5238c5
commit 44d9fbb
Showing 1 changed file with 16 additions and 14 deletions.
diff --git a/src/lib/FieldType/ImageAsset/Type.php b/src/lib/FieldType/ImageAsset/Type.php
@@ -70,20 +70,22 @@ public function validate(FieldDefinition $fieldDefinition, SPIValue $fieldValue)
             (int)$fieldValue->destinationContentId
         );
 
-        if ($this->assetMapper->isAsset($content)) {
-            $validationError = $this->validateMaxFileSize($content);
-            if (null !== $validationError) {
-                $errors[] = $validationError;
-            }
-        } else {
-            $errors[] = new ValidationError(
-                'Content %type% is not a valid asset target',
-                null,
-                [
-                    '%type%' => $content->getContentType()->identifier,
-                ],
-                'destinationContentId'
-            );
+        if (!$this->assetMapper->isAsset($content)) {
+            return [
+                new ValidationError(
+                    'Content %type% is not a valid asset target',
+                    null,
+                    [
+                        '%type%' => $content->getContentType()->identifier,
+                    ],
+                    'destinationContentId'
+                ),
+            ];
+        }
+
+        $validationError = $this->validateMaxFileSize($content);
+        if (null !== $validationError) {
+            $errors[] = $validationError;
         }
 
         return $errors;