cr remarks

ibexa · Jul 5, 2024 · bcaac47 · bcaac47
1 parent 85806bd
commit bcaac47
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 182 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -12235,11 +12235,6 @@ parameters:
 			count: 1
 			path: src/lib/MVC/Symfony/Routing/UrlWildcardRouter.php
 
-		-
-			message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\Security\\\\Authentication\\\\RememberMeRepositoryAuthenticationProvider\\:\\:setPermissionResolver\\(\\) has no return type specified\\.$#"
-			count: 1
-			path: src/lib/MVC/Symfony/Security/Authentication/RememberMeRepositoryAuthenticationProvider.php
-
 		-
 			message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\Security\\\\Authorization\\\\Attribute\\:\\:__construct\\(\\) has parameter \\$function with no type specified\\.$#"
 			count: 1
@@ -47000,16 +46995,6 @@ parameters:
 			count: 1
 			path: tests/lib/MVC/Symfony/Security/Authentication/GuardRepositoryAuthenticationProviderTest.php
 
-		-
-			message: "#^Call to an undefined method Symfony\\\\Component\\\\Security\\\\Core\\\\Authentication\\\\Token\\\\TokenInterface\\:\\:getFirewallName\\(\\)\\.$#"
-			count: 1
-			path: tests/lib/MVC/Symfony/Security/Authentication/RememberMeRepositoryAuthenticationProviderTest.php
-
-		-
-			message: "#^Call to an undefined method Symfony\\\\Component\\\\Security\\\\Core\\\\Authentication\\\\Token\\\\TokenInterface\\:\\:getSecret\\(\\)\\.$#"
-			count: 1
-			path: tests/lib/MVC/Symfony/Security/Authentication/RememberMeRepositoryAuthenticationProviderTest.php
-
 		-
 			message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\Security\\\\HttpUtilsTest\\:\\:checkRequestPathProvider\\(\\) has no return type specified\\.$#"
 			count: 1

diff --git a/src/lib/MVC/Symfony/Security/Authentication/RememberMeRepositoryAuthenticationProvider.php b/src/lib/MVC/Symfony/Security/Authentication/RememberMeRepositoryAuthenticationProvider.php
diff --git a/...ny/Security/Authentication/EventSubscriber/RepositoryUserAuthenticationSubscriberTest.php b/...ny/Security/Authentication/EventSubscriber/RepositoryUserAuthenticationSubscriberTest.php
@@ -80,7 +80,7 @@ public function testAuthenticateInConstantTime(): void
                 $this->getCheckPassportEvent()
             );
         } catch (Exception) {
-            // We don't care, we just need test execution to continue
+            self::fail();
         }
 
         $duration = $stopwatch->stop('authenticate_constant_time_test')->getDuration();
@@ -120,7 +120,7 @@ private function getSubscriber(
         $request = $this->createMock(Request::class);
         $requestStack = $this->createMock(RequestStack::class);
         $requestStack
-            ->method('getCurrentRequest')
+            ->method('getMainRequest')
             ->willReturn($request);
 
         return new RepositoryUserAuthenticationSubscriber(

diff --git a/...ib/MVC/Symfony/Security/Authentication/RememberMeRepositoryAuthenticationProviderTest.php b/...ib/MVC/Symfony/Security/Authentication/RememberMeRepositoryAuthenticationProviderTest.php