Fixed incorrect type-hint for Repository Exceptions contracts (#279)

For more details see #279 * Fixed incorrect type-hint for Repository Exceptions contracts * [PHPStan] Dropped obsolete error report in tests/.../FilterTest.php
ibexa · Oct 11, 2023 · dcca468 · dcca468
1 parent fcd96d8
commit dcca468
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 8 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -62040,11 +62040,6 @@ parameters:
 			count: 1
 			path: tests/lib/Repository/Values/ContentType/FieldDefinitionCollectionTest.php
 
-		-
-			message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertContainsEquals\\(\\) with Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\SortClause\\\\Location\\\\Priority and array\\{\\} will always evaluate to false\\.$#"
-			count: 1
-			path: tests/lib/Repository/Values/Filter/FilterTest.php
-
 		-
 			message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Values\\\\Filter\\\\FilterTest\\:\\:getComplexFilterTestData\\(\\) return type has no value type specified in iterable type iterable\\.$#"
 			count: 1

diff --git a/src/contracts/Persistence/Content/UrlAlias/Handler.php b/src/contracts/Persistence/Content/UrlAlias/Handler.php
@@ -204,7 +204,7 @@ public function deleteCorruptedUrlAliases();
      *
      * @param int $locationId
      *
-     * @throws \Ibexa\Core\Base\Exceptions\BadStateException
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\BadStateException
      */
     public function repairBrokenUrlAliasesForLocation(int $locationId);
 }

diff --git a/src/contracts/Repository/UserPreferenceService.php b/src/contracts/Repository/UserPreferenceService.php
@@ -24,7 +24,7 @@ interface UserPreferenceService
      * @param \Ibexa\Contracts\Core\Repository\Values\UserPreference\UserPreferenceSetStruct[] $userPreferenceSetStructs
      *
      * @throws \Ibexa\Contracts\Core\Repository\Exceptions\UnauthorizedException If the current user user is not allowed to set user preference
-     * @throws \Ibexa\Core\Base\Exceptions\InvalidArgumentException If the $userPreferenceSetStruct is invalid
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\InvalidArgumentException If the $userPreferenceSetStruct is invalid
      */
     public function setUserPreference(array $userPreferenceSetStructs): void;
 

diff --git a/src/lib/Base/Container/ApiLoader/RepositoryFactory.php b/src/lib/Base/Container/ApiLoader/RepositoryFactory.php
@@ -121,7 +121,7 @@ public function buildRepository(
      * @param \Ibexa\Contracts\Core\Repository\Repository $repository
      * @param string $serviceName
      *
-     * @throws \Ibexa\Core\Base\Exceptions\InvalidArgumentException
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\InvalidArgumentException
      *
      * @return mixed
      */