-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-6282: Added attributes support for generating name schema #257
Conversation
0aa6e59
to
48b6411
Compare
2651348
to
1cf2892
Compare
194b24a
to
0bc36a4
Compare
src/contracts/Event/NameSchema/ResolveContentNameSchemaEvent.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this this remark hasn't been incorporated: https://github.com/ibexa/core/pull/257/files#r1304080695.
3e0fce6
to
41217c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Publishing product with name pattern <name>-<attribute:battery_type>-<attribute:disk_size>
causes error:
Ibexa\ProductCatalog\Event\NameSchemaSubscriber::getProductSpecificationFieldFromEvent(): Return value must be of type ?Ibexa\ProductCatalog\FieldType\ProductSpecification\Value, array returned
2eb8749
to
12150d1
Compare
5feb230
to
d111bde
Compare
src/contracts/Event/NameSchema/ResolveContentNameSchemaEvent.php
Outdated
Show resolved
Hide resolved
src/lib/Repository/NameSchema/UnresolvedTokenNamesException.php
Outdated
Show resolved
Hide resolved
d0a0698
to
1ca59c0
Compare
Co-authored-by: Andrew Longosz <[email protected]>
Co-authored-by: Andrew Longosz <[email protected]>
Co-authored-by: Andrew Longosz <[email protected]>
Co-authored-by: Paweł Niedzielski <[email protected]>
Co-authored-by: Andrew Longosz <[email protected]>
5e8370d
to
0359960
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using attributes in product name pattern works fine now.
Previous issues have been resolved.
QA Approved on Ibexa Commerce 4.6.x-dev.
v4.6
This PR added significant changes to content naming in the system, introducing custom name schemas using attributes. The name schema pattern used in these events matches the URL Alias schema pattern for consistency.
Added two new events:
\Ibexa\Contracts\Core\Event\NameSchema\ResolveNameSchemaEvent
and\Ibexa\Contracts\Core\Event\NameSchema\ResolveContentNameSchemaEvent
, enabling dynamic name schemas for content.Refactored names:
resolve()
=>resolveNameSchema()
resolveNameSchema()
=>resolveContentNameSchema()
Checklist:
$ composer fix-cs
).@ibexa/engineering
).