Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6481: Fixed keys in array returned by VersionValidator::validate #271

Merged
merged 8 commits into from
Sep 27, 2023
Merged

IBX-6481: Fixed keys in array returned by VersionValidator::validate #271

merged 8 commits into from
Sep 27, 2023

Conversation

papcio122
Copy link
Contributor

@papcio122 papcio122 commented Sep 6, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-6481
Type bug
Target Ibexa version v4.5
BC breaks no

Change the return array key of VersionValidator:validate() so it is consistent with the PHP doc for the function

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@papcio122 papcio122 requested a review from a team September 6, 2023 06:39
@papcio122 papcio122 force-pushed the IBX-6481-change-VersionValidator-return-array-keys branch from 5fe00d7 to 5f8305e Compare September 11, 2023 13:04
@papcio122 papcio122 requested review from a team and removed request for a team September 11, 2023 13:06
@alongosz alongosz self-requested a review September 12, 2023 16:08
@alongosz alongosz changed the title IBX-6481 changed keys in array returned by VersionValidator:validate() IBX-6481: Changed keys in array returned by VersionValidator:validate() Sep 13, 2023
@papcio122 papcio122 requested review from Steveb-p and a team and removed request for a team September 15, 2023 07:35
alongosz
alongosz reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: SonarCloud report is valid, but out of scope here.
One remark:

src/contracts/Repository/Validator/ContentValidator.php Outdated Show resolved Hide resolved
@Steveb-p Steveb-p requested a review from alongosz September 18, 2023 13:26
@Steveb-p
Copy link
Contributor

Steveb-p commented Sep 18, 2023 •
edited
Loading

@alongosz See edae605 and 8d55651 for changes necessary to facilitate the new declarations.

EDIT: And 929e75e for the baseline changes.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
5.7% 5.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@alongosz alongosz changed the title IBX-6481: Changed keys in array returned by VersionValidator:validate() IBX-6481: Fixed keys in array returned by VersionValidator::validate Sep 19, 2023
@alongosz alongosz requested a review from a team September 19, 2023 08:46
tomaszszopinski
tomaszszopinski approved these changes Sep 27, 2023
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved IbexaDXP 4.5 commerce.

@alongosz alongosz merged commit 0edee54 into 4.5 Sep 27, 2023
1 check failed
@alongosz alongosz deleted the IBX-6481-change-VersionValidator-return-array-keys branch September 27, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ms2ad ms2ad ms2ad left review comments

@Steveb-p Steveb-p Steveb-p approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@konradoboza konradoboza konradoboza approved these changes

@ViniTou ViniTou ViniTou approved these changes

@alongosz alongosz alongosz approved these changes

Assignees

@kisztof kisztof

@mikadamczyk mikadamczyk

@alongosz alongosz

Labels
QA approved Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@papcio122 @Steveb-p @alongosz @ViniTou @konradoboza @tomaszszopinski @ms2ad @kisztof @mikadamczyk