Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6738: Fixed content type group deletion when it contains orphaned content type drafts #282

Merged
merged 3 commits into from
Oct 23, 2023
Merged

IBX-6738: Fixed content type group deletion when it contains orphaned content type drafts #282

merged 3 commits into from
Oct 23, 2023

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Oct 11, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-6738
Type bug
Target Ibexa version v4.5+
BC breaks no

Added logic to delete orphaned content type drafts together with deleted content type group in \Ibexa\Contracts\Core\Repository\ContentTypeService::deleteContentTypeGroup method.

Failing build: https://github.com/ibexa/core/actions/runs/6486424456/job/17614585158?pr=282

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@adamwojs adamwojs requested a review from a team October 11, 2023 19:02
@adamwojs
Copy link
Member Author

Thank you for a code review @alongosz. I will address your comments when I'm will be back from business trip.

@adamwojs adamwojs requested review from alongosz and a team October 15, 2023 09:36
@adamwojs adamwojs added the Bug Something isn't working label Oct 15, 2023
@alongosz alongosz requested a review from a team October 16, 2023 09:05
@konradoboza konradoboza requested a review from a team October 16, 2023 09:07
@katarzynazawada katarzynazawada mentioned this pull request Oct 23, 2023
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adamwojs adamwojs merged commit a204bcf into 4.5 Oct 23, 2023
22 checks passed
@adamwojs adamwojs deleted the ibx_6738 branch October 23, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@konradoboza konradoboza konradoboza approved these changes

@alongosz alongosz alongosz approved these changes

@kisztof kisztof kisztof approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adamwojs @kisztof @alongosz @konradoboza @katarzynazawada