-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-6620: Added image search criterions #284
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciastektk
force-pushed
the
ibx-6620-added-image-search-criterions
branch
3 times, most recently
from
October 18, 2023 09:32
ab4cf7f
to
f8d8834
Compare
ciastektk
force-pushed
the
ibx-6620-added-image-search-criterions
branch
17 times, most recently
from
October 26, 2023 12:26
9d43358
to
e161218
Compare
ciastektk
force-pushed
the
ibx-6620-added-image-search-criterions
branch
from
October 27, 2023 10:08
e161218
to
5840b37
Compare
ciastektk
force-pushed
the
ibx-6620-added-image-search-criterions
branch
2 times, most recently
from
November 3, 2023 12:01
61af225
to
f5ee9c8
Compare
6 tasks
ciastektk
force-pushed
the
ibx-6620-added-image-search-criterions
branch
from
November 6, 2023 12:22
f5ee9c8
to
94d4e03
Compare
ViniTou
approved these changes
Nov 8, 2023
...ontracts/Repository/Values/Content/Query/Criterion/Image/AbstractImageCompositeCriterion.php
Show resolved
Hide resolved
Co-authored-by: Dawid Parafiński <[email protected]>
ciastektk
force-pushed
the
ibx-6620-added-image-search-criterions
branch
from
November 9, 2023 10:01
18ccfb8
to
e012b49
Compare
ciastektk
force-pushed
the
ibx-6620-added-image-search-criterions
branch
from
November 9, 2023 10:58
e012b49
to
07d16be
Compare
ciastektk
force-pushed
the
ibx-6620-added-image-search-criterions
branch
from
November 13, 2023 07:27
25d2284
to
2320f67
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
ciastektk
added
Doc needed
The changes require some documentation
Ready for QA
and removed
Ready for review
labels
Nov 13, 2023
kisztof
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.6
Requires:
ibexa/solr#55
https://github.com/ibexa/elasticsearch/pull/29
ibexa/rest#76
This PR adds new criteria that allows to search images.
Examples:
FileSize criterion:
Criterion to filter by image size.
min_size
- Minimum file size in MBmax_size
- Maximum file size in MBWidth criterion:
Criterion to filter by image width.
min_value
- Minimum file size in pixelsmax_value
- Maximum file size in pixelsHeight criterion:
Criterion to filter by image height.
min_value
- Minimum file size in pixelsmax_value
- Maximum file size in pixelsMimeType criterion:
Criterion to filter by image mime type.
type
- string or array, e.g.: image/pngOrientation criterion:
Criterion to filter by image orientation.
orientation
- string or array. Allowed orientation types: portrait, landscape, square.Dimensions criterion:
Composite criterion to filter by image dimensions.
data
- allowed criteria width, height. All criteria are optional.Image criterion:
Composite criterion to filter by image attributes.
data
- allowed criteria mimeTypes, size,width, height,orientation. All criteria are optional.Checklist:
$ composer fix-cs
).@ibexa/engineering
).