IBX-6630: Allowed injecting view type into content preview controller

[alongosz]

Question	Answer
JIRA issue	IBX-6630
Required by	ibexa/page-builder#273
Type	feature
Target Ibexa version	v4.6
BC breaks	no

This PR allows passing optional {viewType} route attribute query parameter for core content preview controller (ibexa.controller.content.preview:previewContentAction).

Preview Controller builds parameters for ViewController::viewAction and forwards request to that controller. It seems full view type is hardcoded there. Till now it was enough because type of template for preview was based solely on a SiteAccess and the same was used both for view and preview.

However, there are some cases, like back-office customizable Dashboard when we have 2 types of content views needed: regular AdminUI content/location view and the actual dashboard page preview also displayed in the context of admin SiteAccess. This enhancement adds more flexibility to other use cases apart from closed-source Dashboard.

Update

For a good beginning of the weekend, I refactored PreviewControllerTest to actually test what it's supposed to test, in a more compact and modern way. I recommend either reviewing the whole test class or just the diff for the test of the essence of the current changes (6ed7e4e).

TODO

• Update \Ibexa\Tests\Core\MVC\Symfony\Controller\Controller\Content\PreviewControllerTest.

Checklist:

• Provided PR description.
• Tested the solution manually.
• Provided automated test coverage.
• Checked that target branch is set correctly (main for features, the oldest supported for bugs).
• Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
• Asked for a review.

[ViniTou]

Aside remarks from @Steveb-p

[konradoboza]

Apart from Paweł's comments which I agree with.

[Steveb-p]

Out of curiosity, do we even need to be aware of the defaults both here and in the caller? Doesn't admin UI fall back into a full view on it's own? If so, you might want to remove the default and just pass null.

[alongosz]

Out of curiosity, do we even need to be aware of the defaults both here and in the caller? Doesn't admin UI fall back into a full view on it's own? If so, you might want to remove the default and just pass null.

viewType is a core concept. Even if somehow AdminUI does this on its own, this would be a break in core behavior for anyone directly using that controller. While there's no BC promise on that, since the class is neither final nor internal, this is very low cost to at least try keeping that BC.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[alongosz]

Merging to unblock a lot of other dependent Pull Requests. Will be sent to QA with Dashboard feature when ready. For now performed some manual tests to make sure it doesn't break anything.