Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch '1.3' of ezsystems/ezplatform-kernel into 4.5 #286

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

ezrobot
Copy link

@ezrobot ezrobot commented Oct 19, 2023

Cross merge PR of ezsystems/ezplatform-kernel#388.

For more details see https://issues.ibexa.co/browse/IBX-6631 and ezsystems/ezplatform-kernel#388

Key changes:

* Enriched `TrashItem` with `removedLocationContentIdMap`
   API `TrashItem` object, when returned as a result of `TrashService::trash` operation, contains a scalar key->value map of trashed Location ID to its Content ID. It includes trashed subtree Locations. Available also via `TrashEvent` to delegate handling of trashed subtree, if needed.

* [Tests] Added an integration test coverage for the change
@adamwojs
Copy link
Member

@barw4 Rebase is needed here

@barw4 barw4 self-assigned this Oct 20, 2023
@barw4 barw4 requested a review from alongosz October 20, 2023 08:32
@alongosz alongosz requested a review from a team October 20, 2023 10:34
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low-hanging fruit, we try to improve codebase whenever it's feasible, even on merge-ups:

src/contracts/Persistence/Content/Location/Trashed.php Outdated Show resolved Hide resolved
src/lib/Repository/Values/Content/TrashItem.php Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alongosz alongosz merged commit f836872 into 4.5 Oct 20, 2023
23 checks passed
@alongosz alongosz deleted the temp_1.3_to_4.5 branch October 20, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants