Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6641: "is_thumbnail" enabled by default for user_type #290

Merged
merged 1 commit into from
Nov 2, 2023
Merged

IBX-6641: "is_thumbnail" enabled by default for user_type #290

merged 1 commit into from
Nov 2, 2023

Conversation

kisztof
Copy link
Contributor

@kisztof kisztof commented Oct 30, 2023

Question Answer
JIRA issue IBX-6641
Type feature
Target Ibexa version v4.6
BC breaks no

This PR adds is_thumbnail enabled by default

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kisztof kisztof requested a review from a team October 30, 2023 12:38
@Steveb-p Steveb-p requested a review from a team October 30, 2023 12:41
mnocon
mnocon approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with MySQL and PostgreSQL, looks good!

@Steveb-p Steveb-p merged commit 49d459b into main Nov 2, 2023
22 checks passed
@Steveb-p Steveb-p deleted the IBX-6641-user-type-is-thumbnail-true-by-default branch November 2, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@ViniTou ViniTou ViniTou approved these changes

@mnocon mnocon mnocon approved these changes

@ciastektk ciastektk ciastektk approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

Assignees
No one assigned
Labels
QA approved Ready for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kisztof @Steveb-p @ciastektk @mnocon @ViniTou @konradoboza