Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Improvements to Solr image publishing #304

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

mnocon
Copy link
Contributor

@mnocon mnocon commented Dec 7, 2023

Follow-up with the suggestions made in #303

  1. First commit is the file rename - no other changes
  2. Second commit adds:
  • cron schedule (run once every month)
  • image testing - Solr integration tests are run after the image is built and tagged. The image will be pushed if one of the conditions is met:
    a) if the tests are successful
    b) if the force input has been checked in manual dispatch

I've run some tests, here is the summary: (things to look at: test result and the Debug step):

  1. Standard build (cron): https://github.com/ibexa/core/actions/runs/7186371453/job/19571619912?pr=304 . Does not publish the image on test fail.
  2. Manual build without the force flag: https://github.com/ibexa/core/actions/runs/7186411004 Does not publish the image on test fail.
  3. Manual build with force flag: https://github.com/ibexa/core/actions/runs/7186412982 Publishes new image on test fail.
  4. Build with the tests passing (https://github.com/ibexa/core/actions/runs/7186467402/job/19571912873?pr=304)

@mnocon mnocon force-pushed the docker-solr-followup branch 7 times, most recently from 3f35cfc to e2544ba Compare December 12, 2023 20:05
@mnocon mnocon marked this pull request as ready for review December 12, 2023 20:06
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
2.4% Duplication on New Code

See analysis details on SonarCloud

@mnocon mnocon force-pushed the docker-solr-followup branch from e2544ba to 4597488 Compare February 5, 2024 10:02
@alongosz alongosz requested review from Steveb-p and a team February 5, 2024 13:48
.github/workflows/gha-docker-solr.yaml Outdated Show resolved Hide resolved
@konradoboza konradoboza requested a review from a team February 6, 2024 07:19
Co-authored-by: Konrad Oboza <[email protected]>
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
1.1% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz merged commit 565bb77 into ibexa:main Feb 8, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants