Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes PhpDoc #311

Merged
merged 7 commits into from
Apr 16, 2024
Merged

Fixes PhpDoc #311

merged 7 commits into from
Apr 16, 2024

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Dec 18, 2023

Question Answer
JIRA issue IBX-4929
Type bug
Target Ibexa version v4.6
BC breaks no
  • A dollar sign was missing from phpDoc's property declaration (which is preferred to the PHP property declaration by phpDocumentor);
  • Hide some PHPStan 's specific TKey and TValue from phpDocumentor output.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adamwojs
Copy link
Member

@adriendupuis We need rebase here

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adriendupuis adriendupuis changed the base branch from main to 4.6 April 16, 2024 14:26
@adriendupuis adriendupuis marked this pull request as ready for review April 16, 2024 14:36
@adamwojs adamwojs merged commit f1ce2b2 into 4.6 Apr 16, 2024
26 of 27 checks passed
@adamwojs adamwojs deleted the fix-phpdoc branch April 16, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants