-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-7409: Changed Content Type to content type #316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In translation configuration we have
$container->prependExtensionConfig('jms_translation', [
'configs' => [
'ibexa_core' => [
'output_format' => 'xlf',
],
],
]);
why there is a change of extension from xlf
to xliff
?
the only valid way to extract translations is to run php bin/console translation:extract --config=ibexa_core
src/bundle/Core/Resources/translations/ibexa_repository_exceptions.en.xliff
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the extensive diff I'm not sure if changing PHPDoc comments (especially behat ones, but all in general) is such a good idea. Not saying no, because the changes are for the most part correct, with some remarks I posted below.
What I'm worried about is 1st party compatibility of CI tests. We probably should think with @mnocon how to test this against all packages, because I have a feeling we might test in the other packages against specific case of exception messages. Technically changing exception message between minor releases is a BC break, but it rather affects automated tests only. As long as we won't break our CI, it's fine.
src/bundle/Core/Resources/translations/ibexa_repository_exceptions.en.xliff
Outdated
Show resolved
Hide resolved
src/lib/Search/Legacy/Content/WordIndexer/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
...ersistence/Legacy/Filter/CriterionQueryBuilder/Content/Type/ContentTypeQueryBuildersTest.php
Outdated
Show resolved
Hide resolved
66cab32
to
0f11586
Compare
@Gengar-i translation extraction issue fix has been merged into main and you can now rebase & regenerate translations. |
bb98880
to
3395daa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 but it requires CI (unit, integration) sanity checks for packages which require core (almost all of them) but were not changed for this ticket.
3395daa
to
7cf9a6d
Compare
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 2 New issues |
v4.6
Changed Content Type to Content type
Checklist:
$ composer fix-cs
).@ibexa/engineering
).