Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed phpstan #317

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Fixed phpstan #317

merged 1 commit into from
Jan 8, 2024

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Jan 8, 2024 •
edited
Loading

Question Answer
JIRA issue N/A
Type improvement
Target Ibexa version v4.6
BC breaks no

This PR fixes error reporting by PHPStan: https://github.com/ibexa/core/actions/runs/7444582822/job/20251239290?pr=312#step:6:21

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@ciastektk ciastektk changed the base branch from main to 4.5 January 8, 2024 08:35
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ciastektk ciastektk requested a review from a team January 8, 2024 09:08
@konradoboza konradoboza requested a review from a team January 8, 2024 09:08
@alongosz alongosz merged commit b650333 into 4.5 Jan 8, 2024
27 of 28 checks passed
@alongosz alongosz deleted the fixed-phpstan branch January 8, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

Assignees

@kisztof kisztof

@mikadamczyk mikadamczyk

@alongosz alongosz

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ciastektk @mikadamczyk @Steveb-p @konradoboza @kisztof @alongosz