IBX-7364: Ensured independent property assignment in setPreviewActive method by using clone #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed CI on main. |
ViniTou
force-pushed
the
ibx-7364-siteaccess-preview
branch
2 times, most recently
from
da9df08 to
11e8f97
Compare
adamwojs
approved these changes
Jan 28, 2024
konradoboza
approved these changes
Jan 29, 2024
… method by using clone
ViniTou
force-pushed
the
ibx-7364-siteaccess-preview
branch
from
11e8f97 to
6618445
Compare
|
mnocon
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Tested together with https://github.com/ibexa/site-context/pull/41, looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.6in
\Ibexa\Core\MVC\Symfony\Controller\Content\PreviewController::previewContentActionwhen requesting preview for given siteaccess, that siteaccess then override original one (and everywhere else by reference) in\Ibexa\Bundle\Core\EventListener\SiteAccessListener::onSiteAccessMatch, as those are the same object - because of that, after doing request for preview in site-context, after that request we end up with wrong siteaccess for the rest of logic.Cloning SA object when starting preview action solves reference issue, and still allowes for override
defaultsiteaccess with proper one at request initialization.used in:
https://github.com/ibexa/site-context/pull/28
Checklist:
$ composer fix-cs).@ibexa/engineering).