IBX-3957: Made NOP URL aliases not reusable and original #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
alongosz
approved these changes
Mar 19, 2024
webhdx
approved these changes
Mar 19, 2024
barw4
force-pushed
the
ibx-3957-nop-aliases-not-reusable
branch
from
5337dfd to
d1663c4
Compare
tomaszszopinski
approved these changes
May 6, 2024
|
It should not be possible to rebase this onto the current |
|
Did you mean "It should now be possible" ? :) |
barw4
force-pushed
the
ibx-3957-nop-aliases-not-reusable
branch
from
d1663c4 to
51dfca1
Compare
Yeah... it's a typo... 😊 |
Steveb-p
approved these changes
May 10, 2024
|
@Steveb-p CI fails due to PHPStan issues, this might be caused by the new |
barw4
force-pushed
the
ibx-3957-nop-aliases-not-reusable
branch
from
45a4e65 to
a213b64
Compare
|
3 tasks
barw4
added a commit
that referenced
this pull request
Oct 17, 2024
For more details see https://issues.ibexa.co/browse/IBX-3957 and #350 Breaking change: if there exists a custom URL alias having a path "/a/b" where "a" is a virtual (NOP) entry - not pointing to any content - renaming or creating another content on the same level using a colliding name - "a" in this case - will result in actually creating "/a2" entry, as "/a" is already taken by "/a/b" path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v5.0Reasoning: because
nopaliases are not original and they are reusable creating another alias with the same name will break such an alias, however, imo it should be incremented instead. This will prevent creating exactly the same alias with the same parent and as a result, breaking the old one.Maintainer updates:
Documentation
Breaking change: if there already exists a custom URL alias having path
/a/bwhereais a virtual (NOP) entry - not pointing to any content - renaming or creating another content on the same level using a colliding name -ain this case - will result in actually creating/a2entry, as/ais already taken by/a/bpath.(not sure if wording is good here, might need improvement)
QA
More reasoning behind changes and description what happens was provided here ezsystems/ezplatform-kernel#385 (comment)
We need to test system behavior, find things we missed, edge cases, etc.
Checklist:
$ composer fix-cs).@ezsystems/engineering-team).