-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-8121: Fixed code style for 5.0 #362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no way to review this one due to number of files affected, Github UI just freezes. I am up for merging it as long as related test fails are under control.
86eac28
to
53125da
Compare
@konradoboza I've re-applied the changes and split them into separate commits. That should help a bit with review (if you trust me to put code style changes only in that big commit - which you should not, always double check - I used PHPStorm to skim through changed files, but there is many, many of them 😞). I'd highly suggest merging this without squashing too later. Will try to keep that in mind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't complain, just wanted to point out what I observed. 😉 Thanks for splitting your work into commits, nevertheless I was able to go through roughly 60% of all the changes. All of that looks fine, the rest is in collapse mode which is almost impossible to expand file per file due to UX glitches. Therefore, +1 from my end - I actually do trust that remaining files are good too. 😄
eb2c31a
to
53125da
Compare
f5b6fee
to
72cf197
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Description:
This PR fixes code style issues for Ibexa DXP 5.0.