Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8121: Fixed code style for 5.0 #362

Merged
merged 5 commits into from
May 7, 2024
Merged

Conversation

Steveb-p
Copy link
Contributor

🎫 Issue IBX-8121

Description:

This PR fixes code style issues for Ibexa DXP 5.0.

Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no way to review this one due to number of files affected, Github UI just freezes. I am up for merging it as long as related test fails are under control.

@Steveb-p Steveb-p force-pushed the ibx-8121/fix-5.0-code-style branch from 86eac28 to 53125da Compare April 29, 2024 11:15
@Steveb-p
Copy link
Contributor Author

There is no way to review this one due to number of files affected, Github UI just freezes. I am up for merging it as long as related test fails are under control.

@konradoboza I've re-applied the changes and split them into separate commits. That should help a bit with review (if you trust me to put code style changes only in that big commit - which you should not, always double check - I used PHPStorm to skim through changed files, but there is many, many of them 😞).

I'd highly suggest merging this without squashing too later. Will try to keep that in mind.

Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't complain, just wanted to point out what I observed. 😉 Thanks for splitting your work into commits, nevertheless I was able to go through roughly 60% of all the changes. All of that looks fine, the rest is in collapse mode which is almost impossible to expand file per file due to UX glitches. Therefore, +1 from my end - I actually do trust that remaining files are good too. 😄

@konradoboza konradoboza requested a review from a team April 29, 2024 11:31
@Steveb-p Steveb-p force-pushed the ibx-8121/fix-5.0-code-style branch from eb2c31a to 53125da Compare April 29, 2024 12:47
@Steveb-p Steveb-p force-pushed the ibx-8121/fix-5.0-code-style branch from f5b6fee to 72cf197 Compare May 7, 2024 12:31
Copy link

sonarqubecloud bot commented May 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
12.7% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@Steveb-p Steveb-p merged commit 72cf197 into main May 7, 2024
10 of 13 checks passed
@Steveb-p Steveb-p deleted the ibx-8121/fix-5.0-code-style branch May 7, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants