IBX-8322: Fixed lack of redirections to last visited pages after successful authentication #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
approved these changes
Jun 20, 2024
ciastektk
approved these changes
Jun 21, 2024
This was referenced Jun 21, 2024
konradoboza
force-pushed
the
ibx-8322-revived-redirections-after-login
branch
from
1f9a9b7 to
c2aeeb5
Compare
alongosz
approved these changes
Jun 27, 2024
konradoboza
force-pushed
the
ibx-8322-revived-redirections-after-login
branch
from
c2aeeb5 to
fcae367
Compare
ciastektk
approved these changes
Jun 28, 2024
…essful authentication
konradoboza
force-pushed
the
ibx-8322-revived-redirections-after-login
branch
from
fcae367 to
da9e0d6
Compare
|
katarzynazawada
approved these changes
Jul 1, 2024
barw4
pushed a commit
that referenced
this pull request
Oct 17, 2024
…essful authentication (#389) For more details see https://issues.ibexa.co/browse/IBX-8322 and #389 Key changes: * Fixed lack of redirections to last visited pages after successful authentication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
It seems that
AccessDeniedSubscriberis totally excessive. The lack of redirections is caused by Twig templates that attempt to access user properties which isn't always there - in the new Symfony security mechanism anonymous user is replaced withnullvalue. Related AdminUI PR fixes this issue in all the places I was able to spot.Companion Storefront PR makes sure we won't attempt creating
InvalidArgumentExceptionwithnullvalue which in turn ends up with error.For QA:
Documentation: