IBX-8804: Moved PASSWORD_HASH_OAUTH2
from ibexa/oauth2-client
#419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Mentioned password hash (renamed to
PASSWORD_HASH_INVALID
according to the specification) should be listed as one of the supported ones within Ibexa DXP since we offer OAuth2 integration out of the box. Besides moving it I did the following:src/contracts/Repository/Values/User/User.php
to increase quality,src/lib/Repository/User/PasswordHashServiceInterface.php
,Error : Typed property Ibexa\Contracts\Core\Repository\Values\User\User::$login must not be accessed before initialization
.The last code change however isn't a must, and we can introduce it later on on the occasion of deprecation removal. POV ping @alongosz.
For QA:
Documentation:
Mentioning new
PASSWORD_HASH_INVALID
makes sense. We can also take a note it is utilized withinibexa/oauth2-client
.