Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8804: Moved PASSWORD_HASH_OAUTH2 from ibexa/oauth2-client #419

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

konradoboza
Copy link
Contributor

@konradoboza konradoboza commented Aug 22, 2024

🎫 Issue IBX-8804

Related PRs:

Description:

Mentioned password hash (renamed to PASSWORD_HASH_INVALID according to the specification) should be listed as one of the supported ones within Ibexa DXP since we offer OAuth2 integration out of the box. Besides moving it I did the following:

  • added strict typing to src/contracts/Repository/Values/User/User.php to increase quality,
  • removed deprecated src/lib/Repository/User/PasswordHashServiceInterface.php,
  • removed test scenarios which to me stopped making sense and bringing any value - due to strict typing added we have:
    Error : Typed property Ibexa\Contracts\Core\Repository\Values\User\User::$login must not be accessed before initialization.

The last code change however isn't a must, and we can introduce it later on on the occasion of deprecation removal. POV ping @alongosz.

For QA:

Documentation:

Mentioning new PASSWORD_HASH_INVALID makes sense. We can also take a note it is utilized within ibexa/oauth2-client.

@konradoboza konradoboza force-pushed the ibx-8804-moved-password-hash-oauth2-to-core branch from a4f905d to 40fdf96 Compare August 22, 2024 08:18
@konradoboza konradoboza requested review from a team and alongosz August 22, 2024 09:53
@konradoboza konradoboza force-pushed the ibx-8804-moved-password-hash-oauth2-to-core branch from 40fdf96 to db88889 Compare August 22, 2024 11:03
@alongosz alongosz requested a review from a team August 22, 2024 11:08
@konradoboza konradoboza added the Doc needed The changes require some documentation label Aug 22, 2024
Copy link
Contributor

@glye glye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it remains impossible to enter the regular login flow and pass auth with an empty password string, of course. Something for QA to verify.

@konradoboza konradoboza force-pushed the ibx-8804-moved-password-hash-oauth2-to-core branch from db88889 to e91d560 Compare August 29, 2024 13:14
Copy link

@konradoboza konradoboza merged commit 81784d0 into main Sep 3, 2024
13 checks passed
@konradoboza konradoboza deleted the ibx-8804-moved-password-hash-oauth2-to-core branch September 3, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc needed The changes require some documentation QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants