Added basic Pool implementation #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lserwatka
reviewed
Sep 20, 2024
|
alongosz
approved these changes
Sep 20, 2024
Comment on lines
+21128
to
+21141
| - | ||
| message: "#^Result of \\|\\| is always false\\.$#" | ||
| count: 1 | ||
| path: src/lib/Repository/URLWildcardService.php | ||
|
|
||
| - | ||
| message: "#^Variable \\$patterns in empty\\(\\) always exists and is not falsy\\.$#" | ||
| count: 1 | ||
| path: src/lib/Repository/URLWildcardService.php | ||
|
|
||
| - | ||
| message: "#^Variable \\$placeholders in empty\\(\\) always exists and is not falsy\\.$#" | ||
| count: 1 | ||
| path: src/lib/Repository/URLWildcardService.php |
There was a problem hiding this comment.
Note to self: this is a bug, but we need to make a follow-up for that. Now we need to unblock CI.
adamwojs
approved these changes
Sep 21, 2024
konradoboza
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
This PR moves our current implementation of Pool from the
product-catalogto thecorepackageFor QA:
Documentation: