Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8534: Improved iteration over relation list #444

Merged
merged 5 commits into from
Nov 4, 2024
Merged

IBX-8534: Improved iteration over relation list #444

merged 5 commits into from
Nov 4, 2024

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Oct 25, 2024

🎫 Issue IBX-8534

Description:

For QA:

Documentation:

@ViniTou ViniTou mentioned this pull request Oct 25, 2024
Merged
@ViniTou ViniTou force-pushed the ibx-8534-relation-iterator-adapter branch 2 times, most recently from 0bb1f71 to e100dca Compare October 28, 2024 10:16
@ViniTou ViniTou force-pushed the ibx-8534-relation-iterator-adapter branch from e100dca to b9f0825 Compare October 30, 2024 14:48
@ViniTou ViniTou requested a review from a team October 30, 2024 15:27
alongosz
alongosz reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Foremost I'm missing some minimal test coverage. It can be just unit one. Right now we have a helper which implementation is "danging" - not used anywhere. Any future issues would be visible only from ibexa/rest POV, which is not enough.

Other remarks:

@alongosz alongosz requested a review from a team October 30, 2024 17:58
Steveb-p
Steveb-p reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that a minimal unit test coverage is needed. I see what you're doing and I agree with it.

src/contracts/Repository/Iterator/BatchIteratorAdapter/RelationListIteratorAdapter.php
) {
}

public function fetch(int $offset, int $limit): Iterator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we've probably made a mistake by not marking this BatchIteratorAdapter::fetch as returning Traversable (either Iterator and IteratorAgregate)

@adamwojs & everyone - can we consider expanding return type in 5.x?

@ViniTou ViniTou requested review from Steveb-p and alongosz October 31, 2024 13:00
@alongosz alongosz requested a review from a team November 4, 2024 09:40
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz
Copy link
Member

alongosz commented Nov 4, 2024

No QA required as this doesn't affect production code here. Used by REST and covered by functional tests there.
Merging.

@alongosz alongosz merged commit 0c5f86c into main Nov 4, 2024
13 checks passed
@alongosz alongosz deleted the ibx-8534-relation-iterator-adapter branch November 4, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@alongosz alongosz alongosz approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@tischsoic tischsoic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ViniTou @alongosz @Steveb-p @konradoboza @mikadamczyk @tischsoic