Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-9316: Fixed cpu count for Ibexa Cloud #461

Merged
merged 5 commits into from
Dec 20, 2024
Merged

IBX-9316: Fixed cpu count for Ibexa Cloud #461

merged 5 commits into from
Dec 20, 2024

Conversation

reithor
Copy link
Contributor

@reithor reithor commented Dec 10, 2024 •
edited
Loading

🎫 Issue IBX-9316

For Ibexa Cloud Grid environments, CPU count using "proc/cpuinfo" gives unrealistic (far too high) results.
PR fixes the issue.

Notes:

  • Discussion with cloud support confirmed that using data from /run/config.json is a valid approach.
  • Solution works for my own Ibexa Cloud Grid environment
  • Solution also works for Ibexa Cloud Dedicated environment (CPUs are correctly counted using "proc/cpuinfo" then)

@reithor reithor changed the base branch from main to 4.6 December 10, 2024 16:15
@reithor reithor force-pushed the ibx-9316_fixed-cloud-cpu-count branch from b41308b to f420587 Compare December 10, 2024 16:37
@reithor reithor marked this pull request as ready for review December 10, 2024 17:07
@reithor reithor requested a review from a team December 10, 2024 17:08
alongosz
alongosz reviewed Dec 11, 2024
View reviewed changes
src/bundle/Core/Command/ReindexCommand.php Outdated Show resolved Hide resolved
src/bundle/Core/Command/ReindexCommand.php Outdated Show resolved Hide resolved
src/bundle/Core/Command/ReindexCommand.php Outdated Show resolved Hide resolved
src/bundle/Core/Command/ReindexCommand.php Outdated Show resolved Hide resolved
src/bundle/Core/Command/ReindexCommand.php Outdated Show resolved Hide resolved
@reithor reithor requested a review from alongosz December 11, 2024 12:59
@alongosz alongosz changed the title IBX-9316: Fixed cpu count for cloud IBX-9316: Fixed cpu count for Ibexa Cloud Dec 11, 2024
@konradoboza konradoboza requested a review from a team December 11, 2024 13:31
@tomaszszopinski tomaszszopinski self-assigned this Dec 19, 2024
@tomaszszopinski tomaszszopinski force-pushed the ibx-9316_fixed-cloud-cpu-count branch from 1dfa078 to b1b43a6 Compare December 19, 2024 07:01
tomaszszopinski
tomaszszopinski approved these changes Dec 19, 2024
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on Ibexa 4.6 commerce & ibexa cloud.

@alongosz alongosz mentioned this pull request Dec 19, 2024
Merged
@adamwojs adamwojs force-pushed the ibx-9316_fixed-cloud-cpu-count branch from b1b43a6 to d392327 Compare December 19, 2024 18:09
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@alongosz alongosz merged commit 90f0c81 into 4.6 Dec 20, 2024
22 checks passed
@alongosz alongosz deleted the ibx-9316_fixed-cloud-cpu-count branch December 20, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@konradoboza konradoboza konradoboza approved these changes

@alongosz alongosz alongosz approved these changes

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@tischsoic tischsoic

@tomaszszopinski tomaszszopinski

Labels
QA approved Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@reithor @alongosz @konradoboza @tomaszszopinski @mikadamczyk @tischsoic