IBX-8471: Upgraded codebase to Symfony 7 #501
Draft
+35,698
−70,729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
force-pushed
the
ibx-8471-symfony-7
branch
5 times, most recently
from
b62a943 to
cc1494b
Compare
alongosz
force-pushed
the
ibx-8471-symfony-7
branch
3 times, most recently
from
f4b1909 to
84347ec
Compare
Applied Rectors: * Rector\TypeDeclaration\Rector\ArrowFunction\AddArrowFunctionReturnTypeRector * Rector\TypeDeclaration\Rector\Class_\AddTestsVoidReturnTypeWhereNoReturnRector * Rector\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector * Rector\TypeDeclaration\Rector\ClassMethod\AddParamTypeBasedOnPHPUnitDataProviderRector * Rector\TypeDeclaration\Rector\ClassMethod\AddParamTypeFromPropertyTypeRector * Rector\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationBasedOnParentClassMethodRector * Rector\TypeDeclaration\Rector\ClassMethod\AddVoidReturnTypeWhereNoReturnRector * Rector\TypeDeclaration\Rector\ClassMethod\BoolReturnTypeFromBooleanConstReturnsRector * Rector\TypeDeclaration\Rector\ClassMethod\BoolReturnTypeFromBooleanStrictReturnsRector * Rector\TypeDeclaration\Rector\ClassMethod\NumericReturnTypeFromStrictReturnsRector * Rector\TypeDeclaration\Rector\ClassMethod\NumericReturnTypeFromStrictScalarReturnsRector * Rector\TypeDeclaration\Rector\ClassMethod\ParamTypeByMethodCallTypeRector * Rector\TypeDeclaration\Rector\ClassMethod\ParamTypeByParentCallTypeRector * Rector\TypeDeclaration\Rector\ClassMethod\ReturnNeverTypeRector * Rector\TypeDeclaration\Rector\ClassMethod\ReturnNullableTypeRector * Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromMockObjectRector * Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromReturnDirectArrayRector * Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromReturnNewRector * Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictConstantReturnRector * Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNativeCallRector * Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNewArrayRector * Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictParamRector * Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedCallRector * Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedPropertyRector * Rector\TypeDeclaration\Rector\ClassMethod\ReturnUnionTypeRector * Rector\TypeDeclaration\Rector\ClassMethod\StrictArrayParamDimFetchRector * Rector\TypeDeclaration\Rector\ClassMethod\StrictStringParamConcatRector * Rector\TypeDeclaration\Rector\ClassMethod\StringReturnTypeFromStrictScalarReturnsRector * Rector\TypeDeclaration\Rector\ClassMethod\StringReturnTypeFromStrictStringReturnsRector * Rector\TypeDeclaration\Rector\Class_\PropertyTypeFromStrictSetterGetterRector * Rector\TypeDeclaration\Rector\Class_\TypedPropertyFromCreateMockAssignRector * Rector\TypeDeclaration\Rector\Closure\AddClosureVoidReturnTypeWhereNoReturnRector * Rector\TypeDeclaration\Rector\Closure\ClosureReturnTypeRector * Rector\TypeDeclaration\Rector\Empty_\EmptyOnNullableObjectToInstanceOfRector * Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector * Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictConstructorRector * Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictSetUpRector
alongosz
force-pushed
the
ibx-8471-symfony-7
branch
from
84347ec to
cc1a15b
Compare
Doctrine DBAL upgrade was a combination of: * applying `DoctrineSetList` Rector sets, * manual code style fixes of Rector changes, * manual fixes of issues found by SonarQube PHPStorm plugin, * manual fixes of issues found by PHPStan.
Doctrine DBAL upgrade was a combination of: * applying `DoctrineSetList` Rector sets, * manual code style fixes of Rector changes, * manual fixes of issues found by SonarQube PHPStorm plugin, * manual fixes of issues found by PHPStan, * manual code quality improvements.
…od to remove PDO::FETCH_GROUP usage Extracted getSubtreeContent `$onlyIds` behavior to a separate method as it applies to a different use case on a similar query.
…od implementations
…LogicalAndTest::testHandle test
…LogicalOrTest::testHandle test
…rineDatabaseTest::testCountUserPreferences test
…Test::testObjectProperties test
…testSortContentName test
…testSortContentName test
…testSortContentName test
…testSortFieldNumeric test
…testSortSectionIdentifier test
…testSortSectionName test
…:{testGetFieldDefinition,testHasFieldDefinition, testHasFieldDefinitionOfType} test
…:testSortContentId test
…:testSortContentName test
…:testSortFieldNumeric test
…:testSortFieldText test
…:testSortIsMainLocationAscending test
…:testSortIsMainLocationDescending test
…:testSortLocationId test
…:testSortLocationVisibilityAscending test
…:testSortLocationVisibilityDescending test
…:testSortSectionIdentifier test
…:testSortSectionName test
…a\Core\FieldType\BinaryBase\BinaryBaseStorage\Gateway\DoctrineStorage
…Ibexa\Core\FieldType\BinaryFile\BinaryFileStorage\Gateway\DoctrineStorage
…e\Gateway\DoctrineStorage::removeMimeFromPath
…Ibexa\Core\Persistence\Legacy\Content\Gateway\DoctrineDatabase::deleteTranslatedFields
…ay\DoctrineStorage::extractFilesFromXml
…a\Core\Persistence\Legacy\Content\Gateway\DoctrineDatabase::deleteTranslationFromContentVersions
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Contains other PRs
Merge together with other IBX-8471 Pull Requests
Description:
Upgrading Symfony dependencies to version 7 along with necessary 3rd party packages and codebase changes.
Key changes:
For QA:
Sanity tests and/or regression builds.