-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ez_http_tag_location → ez_http_cache_tag_location #1297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ezsystems/documentation-team Could you please add ez_http_cache_tag_location
and other HTTP cache related function to https://doc.ibexa.co/en/latest/guide/twig_functions_reference/ ?
docs/guide/http_cache.md
Outdated
|
||
For full content tagging when inline rendering, use the following: | ||
|
||
``` html+twig | ||
{{ ez_http_tag_location(location) }} | ||
{{ ez_http_cache_tag_location(location) }} | ||
``` | ||
|
||
2\. `ez_http_tag_relation_ids()` or `ez_http_tag_relation_location_ids()` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely, these functions should also have the ez_http_cache
prefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamwojs
Could you please confirm that
ez_http_tag_relation_ids()
and ez_http_tag_relation_location_ids()
should be updated in the docs to
ez_http_cache_tag_relation_ids()
and ez_http_cache_tag_relation_location_ids()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vidarl ez_http_cache_tag_location
doesn't exist (yet).And the goal of ezsystems/ezplatform-http-cache#143 wasn't to create it. Could it be done in another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ez_http_cache_tag_relation_ids
and ez_http_cache_tag_relation_location_ids
added in ezsystems/ezplatform-http-cache#143
Doc updated in 4f9b410 to have this two new Twig functions with the ez_http_cache_tag_
prefix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we still list the function names that is deprecated? so that people searching for it still finds it?
Not sure how the policy is for deprecated things, honestly @dabrt
We do not mention them in the docs, the policy is to list deprecations, like here: For whatever reason these deprecations have not been reported at v3.0 and this branch has already been abandoned. At this point we should simply replace the deprecated signatures with proper ones. |
Hi @adriendupuis , |
Hello @dabrt |
Bonjour @adriendupuis |
Those Twig function names have been updated in #1403 |
Replace
ez_http_tag_location
(kept for 2.5 BC) withez_http_cache_tag_location
.