Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4064: Fix search dropdown breadcrumbs VS highlight #2558

Merged
merged 2 commits into from
Nov 29, 2024
Merged

IBX-4064: Fix search dropdown breadcrumbs VS highlight #2558

merged 2 commits into from
Nov 29, 2024

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Nov 29, 2024 •
edited
Loading

Question Answer
JIRA Ticket IBX-4064
Versions All
Edition All

Fix how the result breadcrumb is built to not split on highlight.
Little mistake found during #1860 deployement.

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@adriendupuis adriendupuis changed the title IBX-4064: Fix search dropdown breadcrumbs VS highligh IBX-4064: Fix search dropdown breadcrumbs VS highlight Nov 29, 2024
mnocon
mnocon approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@adriendupuis adriendupuis merged commit c636be4 into master Nov 29, 2024
6 checks passed
@adriendupuis adriendupuis deleted the search-fix branch November 29, 2024 15:32
adriendupuis added a commit that referenced this pull request Nov 29, 2024
@adriendupuis
IBX-4064: Fix search dropdown breadcrumbs VS highlight (#2558)
5019e74 
(cherry picked from commit c636be4)
adriendupuis added a commit that referenced this pull request Nov 29, 2024
@adriendupuis
IBX-4064: Fix search dropdown breadcrumbs VS highlight (#2558)
88f3558 
(cherry picked from commit c636be4)
@adriendupuis adriendupuis mentioned this pull request Dec 2, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnocon mnocon mnocon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriendupuis @mnocon