Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-9297: Custom CSS can not be removed from link element #199

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Conversation

GrabowskiM
Copy link
Contributor

@GrabowskiM GrabowskiM commented Dec 11, 2024

🎫 Issue IBX-9297

Description:

For QA:

Documentation:

@GrabowskiM GrabowskiM marked this pull request as draft December 11, 2024 17:05
@GrabowskiM GrabowskiM marked this pull request as ready for review December 12, 2024 08:48
@barbaragr barbaragr self-assigned this Dec 18, 2024
Copy link

@barbaragr barbaragr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. If I click "Remove attributes" button, it clears every field in link pop up, not only Custom attributes field. And if I publish and then go again to edit mode, everything is still visible.
  2. I've noticed that Remove link button removes only field value, in richtext link still exists and if user click Publish button, receives Bad request, "Argument '$xmlDoc' is invalid: Transformation of XML content failed: Error in 0:0: Unhandled link type". Should I report it as follow up? Update: reported in https://issues.ibexa.co/browse/IBX-9366

Copy link

@barbaragr barbaragr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I can select all the options by clicking them. Should it be possible? In this case: https://issues.ibexa.co/browse/IBX-9298 it is set for multiple and checkboxes are displayed.
Screenshot 2025-01-08 at 14 14 50
  1. If I select anything in custom attributes and fill for example Title field and then go out without saving: all the fields are cleared except Custom attributes.
Screenshot 2025-01-08 at 14 24 25

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
10.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@GrabowskiM GrabowskiM requested a review from barbaragr January 13, 2025 15:07
@dew326 dew326 merged commit 21f1dbc into 4.6 Jan 17, 2025
21 of 22 checks passed
@dew326 dew326 deleted the IBX-9297 branch January 17, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants