IBX-9509: Revert deprecation of custom attributes labels extractor #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GrabowskiM
commented
Feb 6, 2025
| @@ -55,7 +52,7 @@ public function extract(): MessageCatalogue | |||
| $catalogue->add($this->createMessage(self::CLASS_LABEL_MESSAGE_ID, 'Class')); | |||
|
|
|||
| foreach ($this->siteAccessList as $scope) { | |||
| if (!$this->configResolver->hasParameter(RichText::ATTRIBUTES_SA_SETTINGS_ID)) { | |||
| if (!$this->configResolver->hasParameter(RichText::ATTRIBUTES_SA_SETTINGS_ID, null, $scope)) { | |||
There was a problem hiding this comment.
Here I'm not sure if extraction should be done in some other way, as without this change none of custom attributes are extracted (as in yaml example in docs https://doc.ibexa.co/en/latest/content_management/rich_text/extend_online_editor/#custom-data-attributes they're in admin_group and default scope for hasParameter is site, at least from my little investigation.
So someone from backend has to verify it 100%. :)
adamwojs
approved these changes
Feb 7, 2025
Steveb-p
changed the title
ciastektk
approved these changes
Feb 7, 2025
konradoboza
approved these changes
Feb 11, 2025
mikadamczyk
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When doing merge up there will be need for extra work, as this class was removed in 5.0 #185
For QA:
Documentation: