Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7806: Added missing random fields in solr schema #72

Merged
merged 3 commits into from
Jul 22, 2024
Merged

IBX-7806: Added missing random fields in solr schema #72

merged 3 commits into from
Jul 22, 2024

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Feb 26, 2024 •
edited
Loading

Question Answer
JIRA issue IBX-7806
Type bug
Target Ibexa version v4.5
BC breaks no

However, it seems that we now have some bigger discrepancies between this repository and what is inside ibexa/solr

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@ViniTou ViniTou requested a review from a team February 26, 2024 12:00
@ViniTou ViniTou requested a review from alongosz February 26, 2024 12:01
@ViniTou ViniTou force-pushed the ibx-7806-random-schema-solr-4.5 branch from ffa827b to 560801c Compare March 27, 2024 12:42
@ViniTou ViniTou changed the base branch from 4.5 to 4.6 March 27, 2024 12:42
ViniTou and others added 2 commits July 9, 2024 10:14
tomaszszopinski
tomaszszopinski approved these changes Jul 22, 2024
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on Ibexa DXP 4.6

@ViniTou ViniTou merged commit 7783ded into 4.6 Jul 22, 2024
8 checks passed
@ViniTou ViniTou deleted the ibx-7806-random-schema-solr-4.5 branch July 22, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@konradoboza konradoboza konradoboza approved these changes

@webhdx webhdx webhdx approved these changes

@adamwojs adamwojs adamwojs approved these changes

@alongosz alongosz Awaiting requested review from alongosz

Assignees

@Nattfarinn Nattfarinn

@webhdx webhdx

Labels
QA approved Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ViniTou @adamwojs @webhdx @konradoboza @tomaszszopinski @Nattfarinn