Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8356: Reworked JWT firewall to be in-tact with the new Symfony auth #122

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

konradoboza
Copy link
Contributor

@konradoboza konradoboza commented Jun 5, 2024

🎫 Issue IBX-8356

Related PRs:

Description:

This PR is about making JWT authentication compliant with the Symfony security changes (and bringing it back in the first place 😅). The main source of truth that was used is https://symfony.com/bundles/LexikJWTAuthenticationBundle/current/index.html#symfony-5-3-and-higher.

Additionally, I used

username_path: JWTInput.username
password_path: JWTInput.password

to make the request payload BC safe (username and password are taken from specific keys from the payload so no changes are needed on consumer's end).

For QA:

Documentation:

If we mention security configuration changes anywhere, we need to include changes from this PR as well.

Copy link

github-actions bot commented Jun 5, 2024

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-122

before executing the recipes.

@alongosz alongosz requested a review from a team June 11, 2024 09:07
@webhdx webhdx requested a review from a team June 12, 2024 12:59
@micszo micszo self-assigned this Jun 19, 2024
Base automatically changed from ibx-8290-re-implement-rest-auth to master June 20, 2024 13:22
@konradoboza konradoboza force-pushed the ibx-8356-removed-authenticatorinterface branch from ae510f9 to a4c9ba9 Compare June 20, 2024 13:51
Copy link

@micszo micszo removed their assignment Jun 25, 2024
@konradoboza konradoboza merged commit bf4c8ff into master Jun 25, 2024
2 checks passed
@konradoboza konradoboza deleted the ibx-8356-removed-authenticatorinterface branch June 25, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc needed The changes require some documentation QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants