IBX-8691: Simplified security config for OAuth2 server usages #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contribution! 🎉 To test the changes please execute: before executing the recipes. |
alongosz
approved these changes
Aug 9, 2024
Steveb-p
approved these changes
Aug 9, 2024
konradoboza
force-pushed
the
ibx-8691-reworked-oauth2-server-security
branch
from
4de58ee to
a4d961d
Compare
micszo
force-pushed
the
ibx-8691-reworked-oauth2-server-security
branch
from
e229418 to
d45e618
Compare
This was referenced Aug 16, 2024
micszo
force-pushed
the
ibx-8691-reworked-oauth2-server-security
branch
3 times, most recently
from
d308bb0 to
84fac46
Compare
micszo
force-pushed
the
ibx-8691-reworked-oauth2-server-security
branch
from
84fac46 to
67b93db
Compare
|
micszo
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
It seems we can get rid of our security layer within
ibexa/oauth2-serverbundle. It comes with simplified firewall configuration as the whole authentication process can be done via 3rd party custom authenticator (League\Bundle\OAuth2ServerBundle\Security\Authenticator\OAuth2Authenticator) referenced just viaoauth2: truekey.Putting that under our recently introduced
ibexa_restfirewall is intentional - config is easier to read as we basically set up a fallback custom authenticator for OAuth2 server use-cases.For QA:
Documentation:
It seems we can adjust the OAuth2 server documentation accordingly.