Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issues reported by phpstan #52

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Fixed issues reported by phpstan #52

merged 2 commits into from
Dec 11, 2024

Conversation

adamwojs
Copy link
Member

🎫 Issue N/A

Description:

Fixed issues reported by phpstan. See https://github.com/ibexa/search/actions/runs/12271834106/job/34239401197?pr=51

For QA:

N/A

Documentation:

N/A

@adamwojs adamwojs requested a review from a team December 11, 2024 08:01
@ciastektk
Copy link
Contributor

ciastektk commented Dec 11, 2024 •
edited
Loading

We can get rid of these errors
https://github.com/ibexa/search/pull/52/files#diff-995edee38ad4f8387e58ebd52c31bcc04c56cc2448d331b1cf5e0b35c57b9efaR239 and https://github.com/ibexa/search/pull/52/files#diff-995edee38ad4f8387e58ebd52c31bcc04c56cc2448d331b1cf5e0b35c57b9efaR244

by add following doc block to PageSearchContentToDataMapper::map():

    /**
     * @param \Pagerfanta\Pagerfanta<\Ibexa\Contracts\Core\Repository\Values\Content\Search\SearchHit> $pager
     *
     * @phpstan-return TData[]
     */

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@adamwojs
Copy link
Member Author

Fixed in a51258f

@adamwojs adamwojs merged commit 3a239e1 into 4.6 Dec 11, 2024
11 checks passed
@adamwojs adamwojs deleted the fixed_phpstan branch December 11, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@ciastektk ciastektk ciastektk approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

Assignees

@tischsoic tischsoic

@ViniTou ViniTou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@adamwojs @ciastektk @mikadamczyk @Steveb-p @konradoboza @tischsoic @ViniTou